[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
From: |
Jamie Lokier |
Subject: |
Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS |
Date: |
Thu, 30 Jul 2009 17:07:17 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Juan Quintela wrote:
> Paolo Bonzini <address@hidden> wrote:
> >> Ok, and what are that options?
> >> Looking at today Makefiles, the only things that I see that the user
> >> could want changing is:
> >> -g
> >> -O2
> >> -fno-strict-aliasing
> >> -fno-unit-at-a-time (ppc)
> >> -msmall-data (alpha)
> >> -mno-sdata (ia64)
> >>
> >> Rest of things are -I/-D stuff, that you don't want to touch from the
> >> command line at all.
>
> Ok, with me, then the proposal is:
> rename CFLAGS into QEMU_CFLAGS
> leave in CFLAGS only "-g -O2"
A good trick is to make sure CFLAGS is included at the _end_ of
QEMU_CFLAGS (or that it comes after QEMU_FLAGS in commands), not
anywhere else:
CFLAGS = -g -O2
QEMU_CFLAGS = -msome-option -fno-strict-aliasing $(CFLAGS)
This way, users can override many options in QEMU_CFLAGS if they have
reason to, by supplying the opposite flag, as options coming later
usually have precedence:
make CFLAGS='-g -O2 -fstrict-aliasing'
==> gcc -msome-option -fno-strict-alising -g -O2 -fstrict-aliasing <- wins
-- Jamie
- [Qemu-devel] [PATCH 27/42] Move to configure CONFIG_SOLARIS libraries needed always, (continued)
- [Qemu-devel] [PATCH 27/42] Move to configure CONFIG_SOLARIS libraries needed always, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 28/42] Move to configure CONFIG_WIN32 libraries needed always, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 29/42] We set -Werror through configure now, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/29
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS,
Jamie Lokier <=
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, malc, 2009/07/30
[Qemu-devel] [PATCH 32/42] move common CFLAGS to configure, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 33/42] Refactor HELPER_CFLAGS, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 31/42] split CFLAGS very long line, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 34/42] move SDL_LIBS Win32 hack to configure, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 35/42] Add libs_softmmu variable, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 36/42] Add SDL_LIBS to libs_softmmu, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 37/42] gcc generates the right dependency for this file, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 39/42] Move sound library selection to sound selection, Juan Quintela, 2009/07/29