[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] [RFC] cleanup cpu-exec.c: consolidate handle_c

From: Filip Navara
Subject: Re: [Qemu-devel] [PATCH] [RFC] cleanup cpu-exec.c: consolidate handle_cpu_signal
Date: Sat, 1 Aug 2009 22:42:09 +0200

On Wed, Apr 22, 2009 at 3:33 AM, Nathan Froyd<address@hidden> wrote:
> handle_cpu_signal is very nearly copy-paste code for each target, with a
> few minor variations.  This patch sets up appropriate defaults for a
> generic handle_cpu_signal and provides overrides for particular targets
> that did things differently.  Fixing things like the persistent (XXX:
> use sigsetjmp) should now become somewhat easier.
> I don't understand what the "activate soft MMU for this block" is trying
> to do.  (Especially since handle_cpu_signal and company are under
>  !defined(CONFIG_SOFTMMU)...)  Even though it appears that if
> cpu_*_handle_mmu_fault ever returns a value > 0, that value is always
> one and therefore that block is superfluous, I've left that cleanup for
> a later time.  Likewise for why x86 has a different EXCEPTION_ACTION
> than everyone else.
> Signed-off-by: Nathan Froyd <address@hidden>

Any plans on reviving this patch? It's definitely a cleanup I am interested in.

Best regards,
Filip Navara

reply via email to

[Prev in Thread] Current Thread [Next in Thread]