[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] isa_reserve_irq()

From: Jes Sorensen
Subject: [Qemu-devel] Re: [PATCH] isa_reserve_irq()
Date: Wed, 12 Aug 2009 17:10:52 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2

On 08/12/2009 04:58 PM, Gerd Hoffmann wrote:
On 08/12/09 16:42, Jes Sorensen wrote:
Hi Gerd,

This looks great! I have implemented isa_reserve_irq() on top of this.
It allows one to reserve ISA irqs without converting them to qdev, which
for certain interrupts makes sense,

which ones?


and I have also made the other users
call it until they are converted to qdev.

I think that deserves a comment clearly stating that this interface is a
(temporary?) thing for not-yet converted devices.

Otherwise it looks fine to me.

If you think it makes sense to convert ferr as well, then I'll be happy
to add the comment.

Anthony also pointed out that hpet shouldn't be on the list - it makes
sense. The BIOS can filter out irq2 based on the irq0override flag, so I
will take out the hpet bits too.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]