|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH 5/8] ide: split away ide-macio.c |
Date: | Wed, 19 Aug 2009 15:05:17 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 08/19/09 12:04, Juan Quintela wrote:
Reviewed-by: Juan Quintela<address@hidden> Reply-to: address@hidden Gerd Hoffmann<address@hidden> wrote:create ide-macio.c and place macio support there. only build ide-macio support for platforms using it.This patches does two things. split ide-macio.c Move losts of constants from ide.c to ide-internal.h I agree with both changes, just noticing that they are doing two things here. Consider to split the changeset if you have to resend the series for any reason. I like the change :)
I've moved things from ide.c to ide-internal.h as needed. Probably better to have a separate patch which creates the final ide-internal.h version instead, will fix for the next version (and also the comments ...).
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |