[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] New VMState table based load/save infrastru

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 0/3] New VMState table based load/save infrastructure
Date: Wed, 19 Aug 2009 17:21:13 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2


- For structures, Kraxel suggested to use a VMSTATE_INCLUDE() instead of
   having to declare a new VMStateInfo struct.  As I already have the new
   struct code working, I sent it with the struct.  Thinking about how to
   implement the VMSTATE_INCLUDE() and which one is easier to use.

Looked at your code and figured the two approaches are not that different. I'd just put the pointer to the chained/included VMStateDescription directly into the VMStateField to avoid the (IMHO pointless) indirection via VMStateInfo.

Also: It would probably useful to have two include modes here: One for embedded structs, i.e. this:

struct dev_state {
  PCIDevice dev;

... and one for referenced structs, i.e. this:

struct dev2_state {
  PCIDevice *dev;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]