qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm s


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm softmmu
Date: Fri, 21 Aug 2009 10:52:43 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3


  # What drivers should we compile
  ssi_bus=no
+stellaris=no

What about calling these CONFIG_SSI CONFIG_STELLARIS etc. already in configure, and initializing them with

: ${CONFIG_SSI=n}
: ${CONFIG_STELLARIS=n}

@@ -2236,6 +2238,10 @@ if test "$ssi_bus" = "yes" ; then
      echo "CONFIG_SSI=y">>  $config_host_mak
  fi

+if test "$stellaris" = "yes" ; then
+    echo "CONFIG_STELLARIS=y">>  $config_host_mak
+fi

Then you can:

1) save duplication using

for i in CONFIG_SSI CONFIG_STELLARIS; do
  case \$$i in
  if test "$config_var" = y; then
    echo "$i=y">> $config_host_mak
  fi
done

2) allow the user to force your choice by setting environment variables when calling configure (not sure how useful this is).

Otherwise, looks nice!

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]