[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 21/23] Port PCIDevice state to VMState

From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH 21/23] Port PCIDevice state to VMState
Date: Fri, 21 Aug 2009 11:14:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 08/21/09 11:01, Juan Quintela wrote:
I agree that the INT32_EQUAL is a bad idea. But that is how
the current code is done.

Consider changing the code then ;)

Beside that we'll have to think about how to handle versioning of
structs.  Do we want vmstate_pci_device (and all others) have its own
version?  Probably makes sense.  Handling this should go into the
generic code then and not be hacked into each structure using

Proper solution here is to use subsections.
Each time that you call VMSTATE_PCI_DEVICE() it sends a subsection
there.  Then we get the versioning by free.  This is how I am thinking
it is the right way to do it.

Yep, something like this.

virtio stuff: the more than I think about it, the easier way is to just
get rid of the whole mess and do something that is sensible.

You are talking about VirtIOPCIProxy I guess?
Yea, that is messy ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]