[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs
Date: Fri, 21 Aug 2009 15:07:15 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

+static void wdt_ib700_init(ISADevice *dev)
+    timer = qemu_new_timer(vm_clock, ib700_timer_expired, NULL);
      register_savevm("ib700_wdt", -1, 0, ib700_save, ib700_load, NULL);
      register_ioport_write(0x441, 2, 1, ib700_write_disable_reg, NULL);
      register_ioport_write(0x443, 2, 1, ib700_write_enable_reg, NULL);

One minor nit: Setting dev->iobase[] to { 0x441, 0x443 } here would be nice as 'info qtree' will show the ports actually used by the device then.

Otherwise the patch series looks good.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]