[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/22] Indirection Cleanup

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 00/22] Indirection Cleanup
Date: Mon, 24 Aug 2009 14:37:00 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 08/24/09 13:03, Juan Quintela wrote:
This patch series clean up "half" converted qemu drivers that had changed from:

struct FOOState


typedef PCIFOOState {
     PCIDevice dev;
     FOOState foo;
} PCIFOOState;

It just moves PCIDevice to be the 1st field of FOOState.

Note that there are a bunch of cases where it actually makes sense to have PCIFOOState because foo can be connected to different busses and thus there is a ISAFOOState (or will be once ISA is qdevified too).

Disclaimer: did't look through the patches yet, just scanned the subjects. But I've seen ne2000 + vga on the list. For both devices ISA variants exist. Likewise OHCI, there are also non-PCI variants.

- pcnet:  It needs a different approach, because it can be both a PCIDevice
   or a SysBus device.

That one too ;)
Why do you want to change it?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]