[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5
Date: Mon, 24 Aug 2009 08:18:14 -0500
User-agent: Thunderbird (X11/20090320)

Ian Jackson wrote:
I would also suggest that you only expose this as an option through qdev properties instead of a new command line option as it should be controllable on a per-device basis.

The reason to disable it is not to prevent the guest breaking the
hardware.  It is to prevent the guest escaping the containment
entirely, which it can probably do if firmware updates are allowed.
This seems to me to be a general property of the guest, rather than of
the device.  So I think disabling it in one place is better.

If you go back to the original thread, the argument against this was that some devices abuse other atapi commands to do firmware updates so you cannot 100% reliably contain this.

But more importantly, and the reason I originally requested this, having a global option bakes knowledge of atapi pass through into vl.c. Making it a qdev property means vl.c does not need explicit knowledge of this mechanism.

I think this is an important change to make for merging.


Anthony Liguori

Patches follow.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]