[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/29] monitor: Setup a QDict with arguments to

From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH 07/29] monitor: Setup a QDict with arguments to handlers
Date: Mon, 24 Aug 2009 14:07:46 -0300

On Mon, 24 Aug 2009 18:25:37 +0200
Markus Armbruster <address@hidden> wrote:

> Luiz Capitulino <address@hidden> writes:
> > With this commit monitor_handle_command() will be able to setup a
> > QDict with arguments to command handlers.
> >
> > However, the current 'args[]' method is still being used, next
> > changes will port commands to get their arguments from the dictionary.
> >
> > Two changes are worth noting:
> >
> > 1. The '/' argument type always adds the following standard keys in the
> > dictionary: 'count', 'format' and 'size'. This way, the argument
> > name used in the 'args_type' string doesn't matter
> Can have at most one '/' argument then.  Hmm.  Document as restriction?

 Yes. There are ways to fix this if needed, but no handler uses more
than one and I don't see a use case for this either.

> > 2. The optional argument type '?' doesn't need to pass the additional
> > 'has_arg' argument, hanlders can do the same check with qdict_exists()

reply via email to

[Prev in Thread] Current Thread [Next in Thread]