[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target.
Date: Wed, 26 Aug 2009 11:32:45 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

On 08/25/2009 09:19 PM, Anthony Liguori wrote:
Avi Kivity wrote:
if (0) is usually optimized away by the compiler.

The default only matters to unmanaged systems. I think we should aim first for working, and later for performance.

An "unmanaged system" includes a standard distribution where the user is using virt-manager.

From the name, I would have thought that virt-manager is a managed system.

That's what led me down this road in the first place.

I don't follow the logic at all. If qemu is started with model= (which I'd guess a managed system will do), it doesn't matter what the default is. If qemu is not started with model= (which I'd expect from command line), then we should make every effort to bring up a working guest.

Have we run out of unintended regressions that we've started to add intended ones?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]