[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/11] ide: add IDEBus struct, cleanups

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 01/11] ide: add IDEBus struct, cleanups
Date: Thu, 27 Aug 2009 18:39:10 -0500
User-agent: Thunderbird (X11/20090320)

Gerd Hoffmann wrote:
The current IDE code uses an array of two IDEState structs to maintain
the IDE bus.  This patch adds a IDEBus to be used instead and does a
bunch of cleanups:

 * move ide bus state from IDEState to IDEBus.
 * drop a bunch of ugly pointer arithmetics to figure the active
   interface, explicitly save the interface number instead.
 * add helper functions to save/restore idebus state.

It also fixes a save/restore bug: loadvm allways stores the command in
the master's IDEState, even when it was saved from the slave.

Can you prepare a patch for stable that just fixes this bug? This sounds like something we want there.

Signed-off-by: Gerd Hoffmann <address@hidden>

Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]