[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3] introduce on_vcpu

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH v3] introduce on_vcpu
Date: Thu, 27 Aug 2009 20:38:56 -0500
User-agent: Thunderbird (X11/20090320)

Glauber Costa wrote:
qemu-kvm uses a TLS variable for that, to guarantee that we're in the same 
as our calling context. I like this idea. if we have io-thread disabled, we're 
in the same thread, and will always execute the function directly as we used to 
before on_vcpu().

I do however remember anthony bending towards issuing a gettid() instead of 
a TLS var. I'm fine with both. Anthony, avi, you guys have a word here?

Since we already keep the tid in the vcpu structure, it seems to make more sense to ask "am I this vcpu thread" by doing gettid() == env->tid than by maintaining a new global tls variable.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]