[Qemu-devel] Re: [PATCH] Remove HAS_YMF262 conditional code

[Juan Quintela]

malc <address@hidden> wrote:
> On Fri, 28 Aug 2009, Juan Quintela wrote:
>
>> malc <address@hidden> wrote:
>> > On Fri, 28 Aug 2009, Juan Quintela wrote:
>> >
>> >> HAS_YMF262 is not defined anywhere, and use functinos that are not
>> >> in the tree.
>> >
>> > It doesn't hurt anyone, and should stay for those who want OPL3.
>> >
>> > [..snip..]
>> 
>> We don't have the functions that they protect from.


> diff --git a/hw/adlib.c b/hw/adlib.c
> index e1e4077..8b77ebd 100644
> --- a/hw/adlib.c
> +++ b/hw/adlib.c
> @@ -42,14 +42,8 @@
>  #define ldebug(...)
>  #endif
>
> -#ifdef HAS_YMF262
> -#include "ymf262.h"

$ find . -type f -name "ymf262.h"
$ 

> -void YMF262UpdateOneQEMU (int which, INT16 *dst, int length);

$ find . -type f -name "*.[ch]" | xargs grep YMF262UpdateOneQEMU
./hw/adlib.c:void YMF262UpdateOneQEMU (int which, INT16 *dst, int length);
./hw/adlib.c:    YMF262UpdateOneQEMU (0, s->mixbuf + s->pos * 2, samples);
$

> -    YMF262TimerOver (0, n);

$ find . -type f -name "*.[ch]" | xargs grep YMF262TimerOver
./hw/adlib.c:    YMF262TimerOver (0, n);
$

> -    status = YMF262Write (0, a, val);

$ find . -type f -name "*.[ch]" | xargs grep YMF262Write
./hw/adlib.c:    status = YMF262Write (0, a, val);
$

I.e. We don't have defined that functions anywhere in the source code.
Are I missing something obvious?

Later, Juan.