[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling
Date: Mon, 31 Aug 2009 10:12:21 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3


Add info command registration to the API and make some devices use it.

Jumping in here with a more general comment ...

I think right now we have _way_ to much register_something functions.
IMHO qdev allows us to kill off most of them. We can stick function pointers (also VMstate pointers) into DeviceInfo instead of registering callbacks.

Short-term (while we are in the "convert-drivers-to-qdev" phase) that will just move the register calls from the driver code to generic qdev code.

Long-term we hopefully can kill the register calls altogether and walk the qdev device tree instead.

User visible monitor commands change: 'info' is replaced by 'dev_info'
and also the parameter name may change, for example 'pic' becomes

Hmm, i8259 isn't converted to qdev yet, so the route outlined above above will not work (yet) for this device ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]