Re: [Qemu-devel] Support NEC PC-98x1 on QEMU

[Alexander Graf]

On 09.09.2009, at 15:29, 武田 俊也 wrote:

> Dear Alexander and Stuart,
>
> Thank you very much for your comment.
> I understand qemu implements rule and I agree with your opinion.
>
> I modified my patch based on the codes received from git yesterday.
> Please refer the attached archive.

Two more things here:

1)

Don't top-post.

Write your reply directly below the text you're referring to. If  
you're not replying to something specific, just write it at the bottom.

That makes it easier to see when something is an answer to something  
different - and it's the way most (all?) open source mailing lists  
work ;-)

2)

Attaching as an archive is really bad for review. Usually I'd just  
comment on code in-line, meaning that I reply to the mail and write my  
comment below the source code line in question.

That doesn't work with attachments, which is why Stuart asked you to  
inline it, and hereby I do too.

As soon as you post an inline version, I'll give you some comments on  
the code :-).

Alex