|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH 2/5] virtio-console: Add support for multiple ports for generic guest-host communication |
Date: | Fri, 11 Sep 2009 11:38:36 -0500 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090825) |
Amit Shah wrote:
There wasn't any consensus; the discussion just ended abruptly.
At least Gerd and I were in violent agreement. I don't think anyone disagreed.
If a user does: qemu -M pc-0.11.0 -virtiocon vc -virtiocon vcThis patch will break that guest. I think the best solution to this isIf there are multiple virtiocon devices specified, the first one will default to port #0. The second one will error out saying port 0 is taken. Isn't different from the current behaviour though.
But that's a problem for -M pc-0.11.0. We need to have a way to specify a command line syntax with -M pc-0.11.0 such that the machine created matches what would have been created with qemu-0.11.0. Otherwise, we have no hope of being able to do live migration or save/restore between versions.
We don't want to add PCI dependency to virtio console. It isn't always used on platforms with PCI.OK; there's a place where I need the qdev pointer from the PCIDevice. Any other way of obtaining that?
Why do you need the qdev pointer?
Need to integrate with QemuOpts.Wondering if it already entered master.. I'll sync up with kraxel if not.
Yup, it's been there for a while.
+ + register_savevm("virtio-console", -1, 2, virtio_console_save, virtio_console_load, s);Should integrate with VMState.I don't think virtio devices have been converted yet.
I think that's next on Juan's list. Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |