Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h

[Blue Swirl]

On Fri, Sep 11, 2009 at 11:19 PM, Markus Armbruster <address@hidden> wrote:
> xilinx.h defines a couple of static inline functions for creating
> devices.  While that's a fair technique for hot functions, device
> initialization is about as cold as it gets.  Define them in the device
> source files instead, and keep only declarations in the header.

If I understood the qdev plan correctly, this is going to wrong
direction. These functions should reside near the instantiation, not
in the device code. The current approach looks OK if there are going
to be more users of the devices.