|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) |
Date: | Wed, 30 Sep 2009 16:00:17 -0500 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090825) |
Paolo Bonzini wrote:
We could also select a new style, like Linux kernel one. I'm also not a great fan of that either. But at least 'indent' could be used very easily and I think there would be other benefits, like reuse of Git hooks, patch checking scripts and Emacs configs. With full 'indent' support all sources could be massaged mechanically to make the switch less painful. Then there are K&R and GNU styles, but I like them even less.So ... Linux kernel style wins? What do others think?Linux kernel with 4-char indent? That would avoid the need to run indent (indent requires knowledge of all the names of the types, so a mechanical pass through the sources is more easily said than done).
I strongly disagree with running indent against the source tree. Indentation is purely cosmetic and honestly is something people get too upset about. Doing something like a flag day indent run would result in git annotate becoming more or less useless.
I prefer having tools that we can use to debug real code instead of worry about indentation.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |