[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state
From: |
malc |
Subject: |
Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state |
Date: |
Thu, 1 Oct 2009 01:19:45 +0400 (MSD) |
On Wed, 30 Sep 2009, Anthony Liguori wrote:
> malc wrote:
> > On Wed, 30 Sep 2009, Anthony Liguori wrote:
> >
> > > So I think we should bump the version of the ac97 format, remove the
> > > active[] array from the vmstate, and then generate it in a post function
> > > that can then be passed to reset_voices().
> > >
> >
> > Yes, however, what bothers me though, is that i ended up NOT doing that
> > when the original code was written, there must have been a reason for me
> > not doing that, and it completely elludes me at the moment, so no this
> > isn't better yet, better yet implies someone having to go through the
> > code and figure out whether it's safe or not.
> >
>
> I'm pretty convinced it's safe. The only way it wouldn't be is if it was
> possible for the active_in/active_out state in AUD to be changed through a
> means other than the device itself. Looking at audio.c, it's not possible.
>
> But I also expect that Juan will be testing this device model when he
> resubmits the patch so that should confirm it.
Okay then, given it is tested.
--
mailto:address@hidden
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, (continued)
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Anthony Liguori, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Anthony Liguori, 2009/09/30
- Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state,
malc <=
[Qemu-devel] [PATCH 28/49] vmstate: port ac97 device, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 29/49] x86: hflags is not modified at all, just save it directly, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 30/49] x86: make a20_mask int32_t, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 31/49] x86: fpuc is uint16_t not unsigned int, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 32/49] x86: fpus is uint16_t not unsigned int, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 33/49] x86: add fptag_vmstate to the state, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 34/49] x86: add pending_irq_vmstate to the state, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 35/49] x86: add fpregs_format_vmstate, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 36/49] x86: mce_banks always have the same size, Juan Quintela, 2009/09/29
[Qemu-devel] [PATCH 37/49] x86: send mce_banks as an array, Juan Quintela, 2009/09/29