[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 02/25] pci: use appropriate PRIs in PCI_DPRINTF(
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 02/25] pci: use appropriate PRIs in PCI_DPRINTF() for portability. |
Date: |
Sun, 4 Oct 2009 11:51:36 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Sat, Oct 03, 2009 at 05:15:54AM +0900, Isaku Yamahata wrote:
> use appropriate PRIs in PCI_DPRINTF() to print pci config space offset
> and value for portability.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Can we just switch to "unsigned" here? There's no reason to force
specific data width: in fact, address is probably a 16 bit value,
and ISO types can be printed with plan printf without format macros.
> ---
> hw/pci.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 4392574..d281ee2 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -561,7 +561,7 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t
> val, int len)
> int config_addr, bus_num;
>
> #if 0
> - PCI_DPRINTF("pci_data_write: addr=%08x val=%08x len=%d\n",
> + PCI_DPRINTF("pci_data_write: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n",
> addr, val, len);
> #endif
> bus_num = (addr >> 16) & 0xff;
> @@ -573,7 +573,8 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t
> val, int len)
> if (!pci_dev)
> return;
> config_addr = addr & 0xff;
> - PCI_DPRINTF("pci_config_write: %s: addr=%02x val=%08x len=%d\n",
> + PCI_DPRINTF("pci_config_write: %s: "
> + "addr=%02x val=%08"PRI32x" len=%d\n",
> pci_dev->name, config_addr, val, len);
> pci_dev->config_write(pci_dev, config_addr, val, len);
> }
> @@ -609,11 +610,12 @@ uint32_t pci_data_read(void *opaque, uint32_t addr, int
> len)
> }
> config_addr = addr & 0xff;
> val = pci_dev->config_read(pci_dev, config_addr, len);
> - PCI_DPRINTF("pci_config_read: %s: addr=%02x val=%08x len=%d\n",
> + PCI_DPRINTF("pci_config_read: %s: "
> + "addr=%02x val=%08"PRIx32" len=%d\n",
> pci_dev->name, config_addr, val, len);
> the_end:
> #if 0
> - PCI_DPRINTF("pci_data_read: addr=%08x val=%08x len=%d\n",
> + PCI_DPRINTF("pci_data_read: addr=%08"PRIx32" val=%08"PRIx32" len=%d\n",
> addr, val, len);
> #endif
> return val;
> --
> 1.6.0.2
>
>
- [Qemu-devel] [PATCH 00/25] pci: various pci clean up and pci express support. V3, Isaku Yamahata, 2009/10/02
- [Qemu-devel] [PATCH 03/25] pci: introduce constant PCI_NUM_PINS for the number of interrupt pins, 4., Isaku Yamahata, 2009/10/02
- [Qemu-devel] [PATCH 16/25] pci: pcie host and mmcfg support., Isaku Yamahata, 2009/10/02
- [Qemu-devel] [PATCH 19/25] pci: use helper function in pci_default_write_config(), Isaku Yamahata, 2009/10/02
- [Qemu-devel] [PATCH 05/25] pci: use PCI_SLOT() and PCI_FUNC()., Isaku Yamahata, 2009/10/02
- [Qemu-devel] [PATCH 21/25] pci: make bar update function aware of pci bridge., Isaku Yamahata, 2009/10/02