[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race whe
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" |
Date: |
Wed, 7 Oct 2009 18:33:29 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Oct 07, 2009 at 11:28:21AM -0500, Anthony Liguori wrote:
>
>> There's nothing to review in this particular case, the thing was plain
>> broken, besides same thing was already discussed between me and
>> Andrzej, see for instance:
>> http://www.mail-archive.com/address@hidden/msg09542.html
>>
>> Needless to say the revert is broken also.
>>
>
> Yeah, I understand the race the original commit fixes but I don't
> understand how the original commit broke WinXP.
>
> Do you have further insight Michael?
Nope, I just bisected and then reverted and tested that this helps.
> Blindly reverting something that
> appears right because of a regression is likely just papering over a
> bigger problem.
>
> Regards,
>
> Anthony Liguori
>
- [Qemu-devel] [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Michael S. Tsirkin, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Anthony Liguori, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread",
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Michael S. Tsirkin, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Michael S. Tsirkin, 2009/10/07
- [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/07
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Jamie Lokier, 2009/10/07
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/07
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Jamie Lokier, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", Jamie Lokier, 2009/10/09
- Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread", malc, 2009/10/09