[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/2] Load SMBIOS entries and files from qemu
|
From: |
Kevin O'Connor |
|
Subject: |
[Qemu-devel] Re: [PATCH 2/2] Load SMBIOS entries and files from qemu |
|
Date: |
Wed, 7 Oct 2009 19:53:26 -0400 |
|
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Oct 07, 2009 at 06:16:51PM +0200, Gleb Natapov wrote:
> Allow SMBIOS fields to be overridden and entries replaced by those
> read from qemu.
>
> This is port of commit f4a09e759469be74e2598758bfae623b555c4cae
> from qemu pc-bios tree.
>
> Signed-off-by: Gleb Natapov <address@hidden>
Two comments:
The smbios code is allocating 2K of high ram for the full table. Now
that tables can be pulled in from qemu, is it assured that the space
wont overflow?
[...]
> +#define load_str_field_with_default(type, field, def) \
[...]
These macros are really ugly - isn't there a better way to do this?
-Kevin