[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR. |
Date: |
Mon, 12 Oct 2009 11:52:25 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Mon, Oct 12, 2009 at 08:50:24AM +0200, Gleb Natapov wrote:
> Send patch with your favorite interpretation to qemu pcbios/seabios.
> The regression concern from my previous mail applicable here as well.
Okay. Can you ack the following?
For ROM, bit 0 is the enable bit, which we not only don't want
to set, but it will stick and make us think it's an I/O port
resource. For I/O and memory BARs bit 0 is read-only, so
it does not matter what we write there.
See Qemu pcbios commit 6ddb9f5c742b2b82b1755d7ec2a127f6e20e3806
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
src/pciinit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/pciinit.c b/src/pciinit.c
index eab082a..d315526 100644
--- a/src/pciinit.c
+++ b/src/pciinit.c
@@ -137,7 +137,7 @@ static void pci_bios_init_device(u16 bdf)
ofs = PCI_ROM_ADDRESS;
else
ofs = PCI_BASE_ADDRESS_0 + i * 4;
- pci_config_writel(bdf, ofs, 0xffffffff);
+ pci_config_writel(bdf, ofs, 0xfffffffe);
val = pci_config_readl(bdf, ofs);
if (val != 0) {
size = (~(val & ~0xf)) + 1;
--
1.6.5.rc2
- [Qemu-devel] [PATCH 1/5] Generate mptable unconditionally., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 5/5] Set the PCI base address to 0xf0000000., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 2/5] Enable power button event generation., Gleb Natapov, 2009/10/11
- [Qemu-devel] [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/11
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/11
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR.,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Michael S. Tsirkin, 2009/10/12
- [Qemu-devel] Re: [PATCH 3/5] Use the correct mask to size the PCI option ROM BAR., Gleb Natapov, 2009/10/12