[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject |
Date: |
Wed, 14 Oct 2009 16:11:36 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Sat, 10 Oct 2009 14:18:03 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>>
>> > Each block device information is stored in a QDict and the
>> > returned QObject is a QList of all devices.
>> >
>> > The QDict contains the following:
>> >
>> > - "device": device name
>> > - "type": device type
>> > - "removable": 1 if the device is removable 0 otherwise
>> > - "locked": 1 if the device is locked 0 otherwise
>> > - "backing_file": backing file name if one is used
>>
>> Isn't this in "interted" rather than here?
>>
>> If yes, the comment in the code needs fixing, too.
>
> Yes, although I don't think I should resend just because of that.
Any other way to reliably avoid commit of a misleading comment with a
misleading commit message?
If it goes in that way, we need to follow up with a commit fixing the
comment.
- Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module, (continued)
[Qemu-devel] [PATCH 03/10] monitor: Convert do_physical_memory_save() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 04/10] monitor: Convert do_migrate() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 05/10] monitor: Convert do_migrate_set_speed() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 06/10] monitor: Convert do_migrate_cancel() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject, Luiz Capitulino, 2009/10/08
Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject, Anthony Liguori, 2009/10/15
[Qemu-devel] [PATCH 07/10] monitor: Convert do_info_migrate() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 09/10] monitor: Convert pci_device_hot_add() to QObject, Luiz Capitulino, 2009/10/08
[Qemu-devel] [PATCH 10/10] monitor: Convert do_pci_device_hot_remove() to QObject, Luiz Capitulino, 2009/10/08
Re: [Qemu-devel] [PATCH v0 00/10]: More QObject conversions, Markus Armbruster, 2009/10/10