[Qemu-devel] Re: [PATCH 12/16] vmware_vga: remove !EMBED_STDVGA code

[andrzej zaborowski]

2009/10/14 Juan Quintela <address@hidden>:
> andrzej zaborowski <address@hidden> wrote:
>> 2009/10/14 Juan Quintela <address@hidden>:
>>> It don't compile.  And the trivial fixes (change vga.foo field to foo field
>>> don't work either.  No output
>>
>> Just a note that there's supposed to be no output because your guest
>> OS (and BIOS) expect the standard VGA functionality to be there.  The
>> define is only useful for debugging vmware_vga or OS driver.  It's ok
>> to drop it if you want.
>
> I preffer to drop it because it has no chance of working (suspend/resume
> code is not there for instance).
>
> Once that we are there.  I did a fast try at enabling DIRECT_VRAM with
> the same not working result.  Any idea if it would make things
> better/fast/... whatever?

Currently it probably makes things slower.  I have not digged through
the newer SDL code deep enough, to tell if it's possible to create a
SDL surface directly from guest RAM provided it's contiguously mapped
on host -- this is what VMware does and it's one of the expected
benefits from using vmware_vga that isn't there, and I think using DGA
saves them another unneeded copy.  This would need reimplementing the
pieces guarded by #ifdef DIRECT_VRAM.

Cheers