[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops |
Date: |
Thu, 29 Oct 2009 14:52:47 +0100 |
On Thu, Oct 29, 2009 at 2:45 PM, <address@hidden> wrote:
[...]
>
> Alrighty then, I did the patch against the latest git and it's rather
> large... but seems to have broken nothing at least in my testing. The
> patch will remove all implicit tcg temp variable allocation and
> deallocation in target-arm/translate.c and make it the responsibility
> of the calling function. At the same time I also removed the new_tmp
> and dead_tmp functions completely because I see no point in only
> tracking some of the 32bit temp variables instead of everything.
> Personally I think the patch makes reading and understanding (and why
> not also writing) the file much easier. I do also have a version that
> has a compile time option of substituting the tcg temp variable alloc/
> dealloc function calls with inline functions that track the usage but
> this is not included with the patch.
I was thinking about alloc/dealloc problems and I think a good way
of detecting issues is to exercise all target instructions. It can be
done easily with some bit trickery for targets with regular encodings.
I have already done so for a new target and this helps a lot; it only
required a few dozens lines of code, but it's hacky :-)
> I'll send the patch shortly, should be nice bed-time reading I
> guess ;) Please comment when you have free time to read it through...
Nice!
Laurent
- Re: [Qemu-devel] [PATCH v2 05/10] target-arm: optimize arm load/store multiple ops, (continued)
[Qemu-devel] [PATCH v2 07/10] target-arm: optimize thumb2 load/store multiple ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 06/10] target-arm: fix neon vsri, vshl and vsli ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 10/10] target-arm: fix neon shift helper functions, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 04/10] target-arm: optimize vfp load/store multiple ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 08/10] target-arm: optimize thumb push/pop ops, juha . riihimaki, 2009/10/24
Re: [Qemu-devel] [PATCH v2 00/10] target-arm: miscellaneous fixes, Aurelien Jarno, 2009/10/25