[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000 fix: read access to some registers is mis

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] e1000 fix: read access to some registers is missing.
Date: Sun, 01 Nov 2009 16:05:32 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4

On 10/31/2009 07:29 PM, Kay Ackermann wrote:

While writing working on an e1000 driver for my university's OS I

noticed that some registers aren't readable in QEMU, but they should

be readable as stated in Intels Driver Developer Manual (and also

verified on real hardware).

diff --git a/hw/e1000.c b/hw/e1000.c

index 028afd1..3987e70 100644

--- a/hw/e1000.c

+++ b/hw/e1000.c

@@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, int) = {

getreg(MANC), getreg(MDIC), getreg(SWSM), getreg(STATUS),

getreg(TORL), getreg(TOTL), getreg(IMS), getreg(TCTL),

getreg(RDH), getreg(RDT), getreg(VET), getreg(ICS),

+ getreg(TDBAL), getreg(TDBAH), getreg(RDBAH), getreg(RDBAL),

+    getreg(TDLEN),        getreg(RDLEN),

[TOTH] = mac_read_clr8, [TORH] = mac_read_clr8, [GPRC] = mac_read_clr4,

[GPTC] = mac_read_clr4, [TPR] = mac_read_clr4, [TPT] = mac_read_clr4,

Oh and is there any specific reason why Jumbo-Frames are limited to 4k instead of i.e. Alteon 9014 bytes?

There used to be a 4K buffer somewhere in the path. I think it's larger now.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]