[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge
Date: Thu, 05 Nov 2009 16:49:44 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4

On 11/05/2009 04:45 PM, Anthony Liguori wrote:
Avi Kivity wrote:
+int net_init_bridge(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan);

Don't we need to tear the interface down after shutdown?

net_init_bridge calls net_tap_fd_init which registers tap_cleanup. That closes the fd and frees associated memory.

The helper does not allocate a persistent tap device so closing the file descriptor is sufficient for cleanup.

Ah, so unclean shutdown will clean up as well.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]