[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qem

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu
Date: Thu, 05 Nov 2009 18:07:58 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4

On 11/05/2009 05:58 PM, Anthony Liguori wrote:
Having the tap accessible to management also allows it to run tcpdump or collect statistics on it at runtime.

I'm not advocating removing -net tap,fd=. But -net bridge is obviously useful and makes writing management tools that do common things easier. Not doing something that helps management tools and command line users tremendously simply because it's possible to do it another way for management tools (but not for command line users) is almost user hostile.

As your patchset shows, it's not "tremendously" difficult. The basic helper (which is all libvirt would need; plus PolicyKit integration) is 200 lines. I don't see why you consider placing functionality in the management stack vs qemu user hostile, considering who our users are.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]