[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB t

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer
Date: Tue, 10 Nov 2009 18:09:58 -0600
User-agent: Thunderbird (X11/20090825)

Scott Tsai wrote:
On Wed, Nov 11, 2009 at 1:06 AM, Luiz Capitulino <address@hidden> wrote:
I'd certainly like to make this code useful for something other than
developer training.
How about a new monitor command "thermometer_set" that works like "mouse_move"?
"thermometer_set" would just set the temperature of the "first"
thermometer device it finds.
 Couldn't the device be a parameter?

 And I'd suggest usb_therm_set for the name.

Looking at the existing "mouse_set" and "mouse_move" monitor commands,
they work on USB, PS/2 and other kinds of mice with "mouse_set" selecting
the mouse device affected by  "mouse_move".
So how about a new command "therm_set" which selects the thermometer
affected by "therm_temp" ?

On a separate note, I understand that if a piece of code is not useful enough
we don't want to merge it to add to the maintenance burden.
I still propose 'usb-gotemp' for merging because the fact that gregkh
could give his
driver tutorial several years in a roll to sizable audiences shows
that there are people out there
interested in getting into Linux driver development.
With this code merged, people could follow the video and slides of his talk
without special hardware and this potentially grows the Linux developer pool.

And if Greg decides to change the device he uses for the tutorial, then in a few years it's not so useful anymore?

That said, if we position this as an example device, I think that makes sense. But that suggests that we should document the heck out of it and make it a learning experience for QEMU too. It could be an example of how to write a simple QEMU device emulation.

That would be interesting independent of Greg's tutorial.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]