[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + commen
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments |
Date: |
Wed, 11 Nov 2009 16:34:49 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Wed, Nov 11, 2009 at 02:16:00PM +0000, Paul Brook wrote:
> On Wednesday 11 November 2009, Michael S. Tsirkin wrote:
> > On Wed, Nov 11, 2009 at 01:45:35PM +0000, Paul Brook wrote:
> > > If you don't need real barriers, then why does the kvm code have them?
> >
> > We need real barriers but AFAIK kvm does not have them :(
> > IOW: virtio is currently broken with kvm, and my patch did
> > not fix this. The comment that I added says as much.
>
> So your code just makes the bug harder to reproduce? Doesn't sound like a
> good
> thing to me.
>
> Paul
There are multiple bugs, I can't fix all of them,
for all architectures, in one patch.
--
MST
- Re: [Qemu-devel] [PATCH] qemu/virtio: make wmb compiler barrier + comments, Paul Brook, 2009/11/10
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Paul Brook, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Paul Brook, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Paul Brook, 2009/11/11
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments,
Michael S. Tsirkin <=
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Paul Brook, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Scott Tsai, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Scott Tsai, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11
- Re: [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Jamie Lokier, 2009/11/12
- [Qemu-devel] Re: [PATCH] qemu/virtio: make wmb compiler barrier + comments, Michael S. Tsirkin, 2009/11/11