[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 11/20] pci: clean up of pci_init_wmask().
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 11/20] pci: clean up of pci_init_wmask(). |
Date: |
Thu, 12 Nov 2009 12:18:46 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Nov 12, 2009 at 02:58:39PM +0900, Isaku Yamahata wrote:
> This patch replaces for loop by memset in pci_init_wmask().
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 67818b7..9698efb 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -426,15 +426,15 @@ static void pci_init_cmask(PCIDevice *dev)
>
> static void pci_init_wmask(PCIDevice *dev)
> {
> - int i;
> int config_size = pci_config_size(dev);
>
> dev->wmask[PCI_CACHE_LINE_SIZE] = 0xff;
> dev->wmask[PCI_INTERRUPT_LINE] = 0xff;
> pci_set_word(dev->wmask + PCI_COMMAND,
> PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);
> - for (i = PCI_CONFIG_HEADER_SIZE; i < config_size; ++i)
> - dev->wmask[i] = 0xff;
> +
> + memset(dev->wmask + PCI_CONFIG_HEADER_SIZE, 0xff,
> + config_size - PCI_CONFIG_HEADER_SIZE);
> }
>
> static void pci_init_wmask_bridge(PCIDevice *d)
> --
> 1.6.0.2
- [Qemu-devel] [PATCH 08/20] pci: s/pci_find_host_bus/pci_find_root_bus/g, (continued)
[Qemu-devel] [PATCH 05/20] pci: rename pci_addr_to_dev(), pcie_mmcfg_addr_to_dev()., Isaku Yamahata, 2009/11/12
[Qemu-devel] [PATCH 11/20] pci: clean up of pci_init_wmask()., Isaku Yamahata, 2009/11/12
- [Qemu-devel] Re: [PATCH 11/20] pci: clean up of pci_init_wmask().,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH 07/20] pci: remove pci_sub_bus() by open coding., Isaku Yamahata, 2009/11/12
[Qemu-devel] [PATCH 18/20] pci: fix pci_config_get_io_base()., Isaku Yamahata, 2009/11/12
[Qemu-devel] [PATCH 16/20] pci: kill goto in pci_update_mappings(), Isaku Yamahata, 2009/11/12