[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ.

From: Christoph Hellwig
Subject: Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ.
Date: Tue, 17 Nov 2009 12:15:14 +0100
User-agent: Mutt/1.3.28i

On Tue, Nov 17, 2009 at 11:17:39AM +0100, Gerd Hoffmann wrote:
> Changes:
>  * Move from open-coded lists to QTAILQ macros.
>  * Move the struct elements to the common data structures
>    (SCSIDevice + SCSIRequest).
>  * Fix request cleanup in the destroy callback.

Perfect, the old, duplicated list handling was quite horrible.

Reviewed-by: Christoph Hellwig <address@hidden>

> +    QTAILQ_REMOVE(&r->req.dev->requests, &r->req, next);
> +    QTAILQ_INSERT_HEAD(&free_requests, &r->req, next);

Would be nice if we had a move from one head to another abstraction.  Or
just a copy of the linux list handling header :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]