[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into gene

From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code.
Date: Tue, 17 Nov 2009 12:27:56 +0000
User-agent: KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; )

On Tuesday 17 November 2009, Christoph Hellwig wrote:
> The subject is a bit confusing - it's not the full request parsing but
> just some helpers.

This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of the commit mesaage, my advice is to 
make both the subject and the body of the commit message independent.

On a more technical note, why aren't you also using this function in scsi-
disc.c? Surely that's the whole point of moving it into common code.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]