[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [RFC v0 00/15] QEMU Monitor Protocol

From: Avi Kivity
Subject: [Qemu-devel] Re: [RFC v0 00/15] QEMU Monitor Protocol
Date: Sun, 22 Nov 2009 11:41:02 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4

On 11/19/2009 06:47 PM, Luiz Capitulino wrote:

Can you post a capture of a few monitor commands through the new protocol?
  Here goes, it's a telnet session:

Looks really good, some comments below.

{"QMP": {"capabilities": []}}

{ "execute": "info", "arguments": { "item": "balloon" } }
{"return": 1024}

1. I see no id attribute, but it's supported, yes?
2. I asked before for info commands to be separated into individual commands ("query-balloon") when in machine mode. You wouldn't write a function info(enum info_thing what), would you? What would its return type be? 3. Quantities, for the machine protocol, should be in natural units (in this case, bytes). The human interface can use kMGT and have some reasonable default.

{ "execute": "info", "arguments": { "item": "balloon" } }
{"return": 512}

{ "execute": "info", "arguments": { "item": "network" } }
{"return": [{"devices": [{"name": "user.0", "info": "net=, restricted=n"}, {"name": "e1000.0", 
"info": "model=e1000,macaddr=52:54:00:12:34:56"}], "id": 0}]}

The internal "info" is very worrying. We need to make sure everything is returned as an object without the need for additional parsing.

{ "execute": "migrate", "arguments": { "detach": "-d", "uri": 
"tcp:localhost:4445" } }
{"error": {"class": "InvalidParameter", "data": {"parameter": "detach", "reason": 
"must be an integer"}}}

I presume true and false would work here?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]