[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting
Date: Mon, 23 Nov 2009 09:22:32 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 11/20/09 18:41, Paul Brook wrote:
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
Add a greeting string to CharDriverState which is printed after
initialization.  Used to have the qemu vc consoles labeled.  This
way we can avoid walking all the chardevs a second time after
initialization just to print the greeting.

I think "greeting" is propagating a bad idea into new code. Much better would
be some form of ID and/or human readable description that can also be used

The naming is only one part of the problem. The second part is that the greeting is printed only for the 'vc' backend (where you really need it because there is no other way to figure what chardev you are looking at when switching screens via Ctrl-Alt-<nr>).

There already is a 'label' field. So we could add a flag instead of a string, then do:

   if (chr->want_greeting)
       qemu_chr_printf(chr, "%s console\n", chr->label);

How about this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]