Re: [Qemu-devel] [PATCH] net: initialize vnet_hdr in net_tap_init()

[Pierre Riteau]

On 24 nov. 2009, at 11:05, Mark McLoughlin wrote:

> Hi Pierre,
> 
> On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote:
>> vnet_hdr is initialized at 1 by default. We need to reset it to 0 if
>> the kernel doesn't support IFF_VNET_HDR.
> 
> Thanks for the patch, but I'd prefer us to make sure we catch all cases.
> 
> Does this work for you?
> 
> Thanks,
> Mark.

No it doesn't fix the problem, since vnet_hdr is then changed to 1 in 
net_tap_init by this line, just before calling tap_open:

    *vnet_hdr = qemu_opt_get_bool(opts, "vnet_hdr", 1);

I run qemu like this: sudo qemu -m 1024 -hda /mnt/hda.img -net 
nic,macaddr=DE:AD:BE:EF:69:25 -net tap,script=/home/priteau/qemu-ifup -boot c 
-vnc 0:0

-- 
Pierre Riteau -- http://perso.univ-rennes1.fr/pierre.riteau/