[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] Makefile: Add missing rule for config-devices.m

From: Stefan Weil
Subject: [Qemu-devel] Re: [PATCH] Makefile: Add missing rule for config-devices.mak
Date: Thu, 26 Nov 2009 11:25:48 +0100
User-agent: Mozilla-Thunderbird (X11/20090707)

Juan Quintela schrieb:
> Stefan Weil <address@hidden> wrote:
>> All files config-devices.mak are copies from files in
>> directory default-configs.
>> Creating these copies during configuration ignores these
>> dependencies and may result in unresolved externals
>> from incremental builds when files in default-configs
>> are modified.
>> By adding a dependency rule to Makefile and executing
>> the copy commands there it is possible to run incremental
>> builds even with modified default-configs.
> But then, if you have modified the file, you lost your changes.
> That file is not overwrote on purpose. Think of it as the .config when
> you compile your kernel. If you don't have one, it gets a default one.
> But if you have one, it will not overwrote it. Not all devices have
> been moved to the config file, but the idea is to move them there.
> Anthony, please don't apply.
> About the problem with bisect, if you start with the lastest version
> config file, it should just work (famous last words).
> Later, Juan.

What about overwriting it automatically when it was not modified
by the user? This would only need a backup copy of the original
default configuration. I assume that most users don't change
config-devices.mak, so they would be happy with this solution.
Calling "make defconfig" is only the second best solution for them.

A more sophisticated solution could try to create a patch from
original default configuration and user modified configuration.
Make could try to apply this patch to the new default configuration,
and if there is no conflict, all is fine as well.

Regards, Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]