qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname(


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname()
Date: Fri, 27 Nov 2009 10:31:24 +0100
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707)

David Benjamin schrieb:
> This should avoid truncating the register name when debugging.
>
> Signed-off-by: David Benjamin <address@hidden>
> ---
> hw/eepro100.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 8734907..3676dc0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -648,7 +648,7 @@ static const char * const reg[PCI_IO_SIZE / 4] = {
>
> static char *regname(uint32_t addr)
> {
> - static char buf[16];
> + static char buf[32];
> if (addr < PCI_IO_SIZE) {
> const char *r = reg[addr / 4];
> if (r != 0) {

This was already fixed in the latest version of eepro100.c
(git://repo.or.cz/qemu/ar7.git).

In "official" QEMU on savannah, it is still missing
(as several other patches, too).

It takes more than a week to get a patch integrated...

Regards,
Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]