[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state |
Date: |
Mon, 30 Nov 2009 14:04:44 +0200 |
On Mon, Nov 30, 2009 at 09:45:56AM -0200, Glauber Costa wrote:
> >> since
> >> + * apic base was just updated
> >> + */
> >> + kvm_arch_put_registers(s->cpu_env);
> >>
> >>
> >
> > Better to use cpu_synchronize_state() instead.
> >
> I might be misreading it, but :
>
> void kvm_cpu_synchronize_state(CPUState *env)
> {
> if (!env->kvm_state->regs_modified) {
> kvm_arch_get_registers(env);
> env->kvm_state->regs_modified = 1;
> }
> }
>
> Only does get. And we need put.
>
Put is on the entry into the kernel in vcpu_run.
--
Gleb.
- [Qemu-devel] [PATCH 0/7] KVM SMP support, early version, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 1/7] Don't mess with halted state., Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 2/7] store thread-specific env information, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 3/7] update halted state on mp_state sync, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 6/7] Don't call kvm cpu reset on initialization, Glauber Costa, 2009/11/26
- [Qemu-devel] [PATCH 7/7] remove smp restriction from kvm, Glauber Costa, 2009/11/26
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Avi Kivity, 2009/11/29
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Glauber Costa, 2009/11/30
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state,
Gleb Natapov <=
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Avi Kivity, 2009/11/30
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Glauber Costa, 2009/11/30
- Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state, Avi Kivity, 2009/11/30
- Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution, Avi Kivity, 2009/11/29
- Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution, Glauber Costa, 2009/11/30
- Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution, Avi Kivity, 2009/11/30
- [Qemu-devel] Re: [PATCH 4/7] qemu_flush_work for remote vcpu execution, Paolo Bonzini, 2009/11/30
- Re: [Qemu-devel] [PATCH 2/7] store thread-specific env information, Avi Kivity, 2009/11/29
- Re: [Qemu-devel] [PATCH 2/7] store thread-specific env information, Andreas Färber, 2009/11/29
- Re: [Qemu-devel] [PATCH 2/7] store thread-specific env information, Avi Kivity, 2009/11/29