Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state

[Glauber Costa]

On Mon, Nov 30, 2009 at 10:05 AM, Avi Kivity <address@hidden> wrote:
> On 11/30/2009 01:45 PM, Glauber Costa wrote:
>>>
>>> Better to use cpu_synchronize_state() instead.
>>>
>>>
>>
>> I might be misreading it, but :
>>
>> void kvm_cpu_synchronize_state(CPUState *env)
>> {
>>     if (!env->kvm_state->regs_modified) {
>>         kvm_arch_get_registers(env);
>>         env->kvm_state->regs_modified = 1;
>>     }
>> }
>>
>> Only does get. And we need put.
>>
>
> It will autoput during the next guest entry.

So it should be working already, no?

We do a cpu_synchronize_state() on the beginning of that function, and
vcpu does not run
until it is finished.

>
> --
> error compiling committee.c: too many arguments to function
>
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."