[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant |
Date: |
Mon, 30 Nov 2009 21:02:26 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
PCI memory should be disabled at reset, otherwise
we might claim transactions at address 0.
I/O should also be disabled, although for cirrus
it is harmless to enable it as we do not
have I/O bar.
Note: bios fix needed for this patch to work
was already applied:
previously bios incorrently assumed that it does not
need to enable i/o unless device has i/o bar.
Signed-off-by: Michael S. Tsirkin <address@hidden>
Acked-by: Juan Quintela <address@hidden>
---
hw/cirrus_vga.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index d76e5bb..e16026f 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -3231,7 +3231,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev)
/* setup PCI */
pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS);
pci_config_set_device_id(pci_conf, device_id);
- pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS;
pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA);
pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL;
--
1.6.5.2.143.g8cc62
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant,
Michael S. Tsirkin <=