|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution |
Date: | Thu, 03 Dec 2009 15:29:25 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/02/2009 02:48 PM, Glauber Costa wrote:
+ if (env == qemu_get_current_env()) {
Will always be false for TCG + iothread. What's wrong with qemu_cpu_self(env)? It appears to do the same, and it would also make the whole thread-local storage stuff redundant.
If there are performance problems, you can fix them by using TLS for the KVM case and keeping the existing implementation for TCG; at which point you can just use __thread because KVM can assume Linux and hence a working __thread.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |