qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code &


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines.
Date: Mon, 07 Dec 2009 14:30:41 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4

On 12/07/09 13:54, Alexander Graf wrote:

On 07.12.2009, at 13:42, Gerd Hoffmann wrote:

Qemu creates a default serial line for you in case you didn't specify
one on the command line.  Right now this is tied to the '-serial
<chardev>' command line switch, which in turn causes trouble if you are
creating your serial line via '-device isa-serial,<props>'.

+static int default_serial = 1;
+
+static struct {
+    const char *driver;
+    int *flag;
+} default_list[] = {
+    { .driver = "isa-serial",           .flag =&default_serial },


What is the "isa-serial" driver supposed to say here?

Yes.

Is that the qdev driver name? If so, that's just plain wrong. PPC for example 
uses the ESCC chip to export its serial port.

Just add the driver name to the list then, so '-device ESCC,...' (or however it is named in qdev) will stop conflicting with the automagically created -serial port too.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]