Re: [Qemu-devel] [FOR 0.12 PATCH v3 17/21] rework -monitor handling, switch to QemuOpts

[Anthony Liguori]

Gerd Hoffmann wrote:
> This patch reworks the -monitor handling:
>
>  - It adds a new "mon" QemuOpts list for the monitor(s).
>  - It adds a monitor_parse() function to parse the -monitor switch.
>  - It adds a mon_init function to initialize the monitor(s) from the
>    "mon" QemuOpts list.
>  - It winds up everything and removes the old bits.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
>   

This SEGVs as Luiz has reported, but it also has some debugging noise in it:

> +static int mon_init_func(QemuOpts *opts, void *opaque)
> +{
> +    CharDriverState *chr;
> +    const char *chardev;
> +    const char *mode;
> +    int flags;
> +
> +    qemu_opts_print(opts, NULL);
>   

Right here.

> +    mode = qemu_opt_get(opts, "mode");
> +    if (mode == NULL) {
> +        mode = "readline";
> +    }
> +    if (strcmp(mode, "readline") == 0) {
> +        flags = MONITOR_USE_READLINE;
> +    } else if (strcmp(mode, "control") == 0) {
> +        flags = MONITOR_USE_CONTROL;
> +    } else {
> +        fprintf(stderr, "unknown monitor mode \"%s\"\n", mode);
> +        exit(1);
> +    }
> +
Regards,

Anthony Liguori