[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V9 06/20] pc: initialize ioapic before use.
From: |
Isaku Yamahata |
Subject: |
[Qemu-devel] [PATCH V9 06/20] pc: initialize ioapic before use. |
Date: |
Tue, 8 Dec 2009 17:33:25 +0900 |
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6
prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic.
However it would be better to initialize the member before reference.
Signed-off-by: Isaku Yamahata <address@hidden>
---
hw/pc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 8c1b7ea..3958874 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1101,6 +1101,9 @@ static void pc_init1(ram_addr_t ram_size,
i8259 = i8259_init(cpu_irq[0]);
isa_irq_state = qemu_mallocz(sizeof(*isa_irq_state));
isa_irq_state->i8259 = i8259;
+ if (pci_enabled) {
+ isa_irq_state->ioapic = ioapic_init();
+ }
isa_irq = qemu_allocate_irqs(isa_irq_handler, isa_irq_state, 24);
if (pci_enabled) {
@@ -1144,9 +1147,6 @@ static void pc_init1(ram_addr_t ram_size,
register_ioport_read(0x92, 1, 1, ioport92_read, NULL);
register_ioport_write(0x92, 1, 1, ioport92_write, NULL);
- if (pci_enabled) {
- isa_irq_state->ioapic = ioapic_init();
- }
pit = pit_init(0x40, isa_reserve_irq(0));
pcspk_init(pit);
if (!no_hpet) {
--
1.6.5.4
- [Qemu-devel] [PATCH V9 15/20] pc: split out vga initialization from pc_init1() into pc_vga_init()., (continued)
- [Qemu-devel] [PATCH V9 15/20] pc: split out vga initialization from pc_init1() into pc_vga_init()., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 10/20] pc: Remove reference to a global variable, RTCState *rtc_state., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 07/20] pc, i440fx: Make smm enable/disable function i440fx independent., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 19/20] pc: move rtc declarations from pc.h into a dedicated header file., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 02/20] acpi: split out apm register emulation from acpi.c, Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 08/20] pc: make an unnecessary global variable, pit, local., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 18/20] pc: split out piix specific part from pc.c into pc_piix.c, Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 09/20] pc: remove a global variable, floppy_controller., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 11/20] pc: introduce a function to allocate cpu irq., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 14/20] pc: split out memory allocation from pc_init1() into pc_memory_init(), Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 06/20] pc: initialize ioapic before use.,
Isaku Yamahata <=
- [Qemu-devel] [PATCH V9 05/20] acpi_piix4: remove unused variable in get_pmsts()., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 13/20] pc: split out cpu initialization from pc_init1() into pc_cpus_init()., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 20/20] rtc: make rtc_xxx accept/return ISADevice instead of RTCState., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 16/20] pc: split out basic device init from pc_init1() into pc_basic_device_init(), Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 04/20] acpi: split acpi.c into the common part and the piix4 part., Isaku Yamahata, 2009/12/08
- [Qemu-devel] [PATCH V9 01/20] acpi: split out pc smbus routines from acpi.c into pc_smbus.c, Isaku Yamahata, 2009/12/08