Re: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing whitespace

[Blue Swirl]

On Wed, Dec 9, 2009 at 11:43 AM, Markus Armbruster <address@hidden> wrote:
> Ian Molton <address@hidden> writes:
>
>> Markus Armbruster wrote:
>>
>>> The place for verbose device names is DeviceInfo member desc.  The
>>> name should be short & sweet.
>>
>> Agreed, however...
>>
>> Why do these (maybe others) get caps in their names? they dont look
>> right to me, compared to the others with nice names like usb-serial,
>> piix-ide, or cirrus-vga.
>>
>>> -    sysbus_register_dev("Uni-north main", sizeof(UNINState),
>>> +    sysbus_register_dev("Uni-north-main", sizeof(UNINState),
>>>                          pci_unin_main_init_device);
>>>      pci_qdev_register(&unin_main_pci_host_info);
>>> -    sysbus_register_dev("DEC 21154", sizeof(UNINState),
>>> +    sysbus_register_dev("DEC-21154", sizeof(UNINState),
>>>                          pci_dec_21154_init_device);
>>>      pci_qdev_register(&dec_21154_pci_host_info);
>>> -    sysbus_register_dev("Uni-north AGP", sizeof(UNINState),
>>> +    sysbus_register_dev("Uni-north-AGP", sizeof(UNINState),
>>>                          pci_unin_agp_init_device);
>>>      pci_qdev_register(&unin_agp_pci_host_info);
>>> -    sysbus_register_dev("Uni-north internal", sizeof(UNINState),
>>> +    sysbus_register_dev("Uni-north-internal", sizeof(UNINState),
>>>                          pci_unin_internal_init_device);
>>>      pci_qdev_register(&unin_internal_pci_host_info);
>>>  }
>
> I can downcase them.  Blue Swirl, any objections?
>

I'd prefer the same names that are used by the device tree, like uni-n
and uni-north-agp. Though the bridge is name poorly, just
"pci-bridge".

For example:
http://penguinppc.org/historical/dev-trees-html/imac_400_1.html