|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property |
Date: | Mon, 14 Dec 2009 11:24:41 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/14/09 10:42, Michael S. Tsirkin wrote:
On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote:On 12/13/09 21:43, Michael S. Tsirkin wrote:Add features property to virtio. This makes it possible to e.g. define machine without indirect buffer support, which is required for 0.10 compatibility. or without hardware checksum support, which is required for 0.11 compatibility.I'd suggest to add flags for the individual features to the drivers which actually use it instead, so you'll have -device virtio-net-pci,hw-checksum=0 and -device virtio-blk-pci,indirect-buffers=0 cheers, GerdHmm. I hoped to avoid it, there are lots of features so it's a lot of work and in practice, this will most likely be set by machine description ...
MSI-X aka vectors property is already done this way, so I'd tend to continue this way. It is also more user friendly. Sure, these are most likely not used on a daily base by users, but being able to turn off -- say -- indirect buffers for testing and/or bug hunting reasons without having to construct magic hex numbers from virtio header files would be nice.
Can you give a list of features? The patch description sounded like it is just the two listed above ...
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |